clintropolis commented on code in PR #18742: URL: https://github.com/apache/druid/pull/18742#discussion_r2537369836
########## server/src/main/java/org/apache/druid/segment/loading/StorageLocationStats.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.loading; + +public interface StorageLocationStats +{ + long getLoadCount(); + + long getLoadBytes(); Review Comment: right now these metrics are all just for the emission period. I was aiming for these metrics to show like the activity during the period to give a good idea of segment cache activity rather than overall usage, the static load metrics showing churn in rebalancing, while the vsf metrics could be used as an indicator that there is a lot of churn from queries targeting different segments competing for disk space. That said, it does feel useful to have some metrics like you are suggesting as well, especially later once we can have mixed disk usage from virtual loads via load rules... will think on it a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
