jtuglu1 commented on issue #18764: URL: https://github.com/apache/druid/issues/18764#issuecomment-3561696908
Think I've RC'd at least one issue: Basically the issue is: 1. Duty group starts 2. build() is called once ([callsite](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java#L743)) - This time [segmentAssigner != null || loadQueueManager == null](https://github.com/apache/druid/blob/-/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorRuntimeParams.java#L277) is false. 3. build() is called again ([callsite](https://github.com/apache/druid/blob/-/server/src/main/java/org/apache/druid/server/coordinator/duty/PrepareBalancerAndLoadQueues.java#L111)) - This time [segmentAssigner != null || loadQueueManager == null](https://github.com/apache/druid/blob/-/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorRuntimeParams.java#L277) is true, so it critically DOESN'T update the thing serverManager for the RunRules (since the parameters are returned + passed to the next rule chain in the duty group). basically, in cases where the load callback happens after the first build() but before duty completion, you get your race. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
