kfaraz commented on code in PR #18777: URL: https://github.com/apache/druid/pull/18777#discussion_r2559766765
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/TaskLockConfig.java: ########## @@ -42,6 +43,13 @@ public class TaskLockConfig @JsonProperty private int batchAllocationNumThreads = 5; + /** + * Undocumented parameter, used for embedded tests that create high partition numbers without needing to + * individually create each segment. Controls the initial partition number to be used for segment allocation. + */ + @JsonProperty + private int initialAllocationPartitionNumber = PartitionIds.ROOT_GEN_START_PARTITION_ID; Review Comment: If this config is to be used only for tests, I would advise a slightly different strategy which wouldn't require touching all the production classes. 1. Use the `ClusterTestingModule` extension in the embedded test and enable it on the Overlord via `druid.unsafe.cluster.testing=true`. 2. Create a new class `FaultyIndexerSQLMetadataStorageCoordinator extends IndexerSQLMetadataStorageCoordinator` and override allocation methods. 3. In `ClusterTestingModule`, do `binder.binder(IndexerSQLMetadataStorageCoordinator.class).to(FaultyIndexer...);` 4. Pass a test config into the faulty implementation to control the `startPartitionId`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
