gianm commented on code in PR #18777: URL: https://github.com/apache/druid/pull/18777#discussion_r2560817949
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/TaskLockConfig.java: ########## @@ -42,6 +43,13 @@ public class TaskLockConfig @JsonProperty private int batchAllocationNumThreads = 5; + /** + * Undocumented parameter, used for embedded tests that create high partition numbers without needing to + * individually create each segment. Controls the initial partition number to be used for segment allocation. + */ + @JsonProperty + private int initialAllocationPartitionNumber = PartitionIds.ROOT_GEN_START_PARTITION_ID; Review Comment: I just pushed a different approach: 1. First insert the test data into a single segment using SQL, with partition 0. 2. Direct insert a new segment into metadata storage that is the same as that first one, but with a partition number of Short.MAX_VALUE 3. Run SQL to insert 3 more segments. 4. Verify all are loaded and queryable. ########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/TaskLockConfig.java: ########## @@ -42,6 +43,13 @@ public class TaskLockConfig @JsonProperty private int batchAllocationNumThreads = 5; + /** + * Undocumented parameter, used for embedded tests that create high partition numbers without needing to + * individually create each segment. Controls the initial partition number to be used for segment allocation. + */ + @JsonProperty + private int initialAllocationPartitionNumber = PartitionIds.ROOT_GEN_START_PARTITION_ID; Review Comment: I removed this new parameter I had added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
