drcrallen commented on a change in pull request #6953: Move GCP to a core
extension
URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r263179414
##########
File path: server/pom.xml
##########
@@ -42,6 +42,11 @@
<artifactId>druid-aws-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.druid</groupId>
+ <artifactId>druid-gcp-common</artifactId>
Review comment:
If they only provided libraries and no bindings it would. But with that
approach it does not allow me to make a third party extension to inject new
overrides to the HttpInitializer (for example).
And since things are bound guice makes the classloader isolation items weird
for classes named the same thing but in different classloaders.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
