gianm commented on a change in pull request #6953: Move GCP to a core extension
URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r263208535
##########
File path: server/pom.xml
##########
@@ -42,6 +42,11 @@
<artifactId>druid-aws-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.druid</groupId>
+ <artifactId>druid-gcp-common</artifactId>
Review comment:
I see. That makes sense and is a bummer. But thanks for explaining it. I
also guess that doing it the way I suggested would mean every extension gets
its own GCP client, which is not ideal. OK, I give up, let's do it this way and
hopefully someone has a flash of inspiration around making extensions able to
depend on other extensions.
I built a tarball to see what new stuff this would add to `lib/`, and got:
```
./lib/checker-qual-2.5.7.jar
./lib/druid-gcp-common-0.15.0-incubating-SNAPSHOT.jar
./lib/google-api-client-1.22.0.jar
./lib/google-http-client-1.22.0.jar
./lib/google-http-client-jackson2-1.22.0.jar
./lib/google-oauth-client-1.22.0.jar
./lib/jackson-module-guice-2.6.7.jar
```
Not too bad! I was afraid it would pull in a bunch of extra deps, but, it
doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
