gianm commented on a change in pull request #6953: Move GCP to a core extension
URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r262649612
##########
File path: server/pom.xml
##########
@@ -42,6 +42,11 @@
<artifactId>druid-aws-common</artifactId>
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.druid</groupId>
+ <artifactId>druid-gcp-common</artifactId>
Review comment:
I wish we didn't have to include gcp-common in the standard lib directory,
even for people that don't use GCP. It feels like continuing the sins of our
forebears (aws-common, that is). Which / how many jars does this end up adding?
Trying to convince myself to be okay with this and not fight it :)
I think you said you tried doing a transitive dependency but had issues with
it. For sake of getting it written down - what'd you try & what went wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
