kfaraz commented on PR #18591: URL: https://github.com/apache/druid/pull/18591#issuecomment-3624383909
Thanks for the update, @FrankChen021 ! My concern was mostly the code structure, the fact that we have to pass around an "effective" config and the merging of static and dynamic configs (even though most of the configs seem to be always static), but we can always address it later if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
