kfaraz commented on PR #18591: URL: https://github.com/apache/druid/pull/18591#issuecomment-3494656823
Apologies! I have been bogged down with a bunch of other stuff, some to do with the D35 release as well. @FrankChen021 , I would really appreciate it if you could hold off on merging this at least until Friday (tomorrow). If I have not found some time to leave any feedback by then, and @cryptoe has approved, you can merge off this PR. @cryptoe and I have discussed this briefly. For the most part, the capabilities added here make sense. But I just want to take a quick pass through the code flow and structure since this is a critical piece of the task management system. We could always merge off this PR and address my comments in a follow up PR but that would only make the changes more difficult to track. I hope that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
