Fly-Style commented on code in PR #18819:
URL: https://github.com/apache/druid/pull/18819#discussion_r2610688644
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1576,6 +1592,83 @@ private Map<String, Map<String, Object>>
getCurrentTotalStats()
return allStats;
}
+ /**
+ * Collect metrics from all tasks managed by this supervisor.
+ * Note that {@code StatsFromTaskResult} are reused for metrics collection
since
+ * both stats and metrics are represented as {@code Map<String, Object>}.
+ *
+ * @return A map of groupId->taskId->task metrics
+ * @throws InterruptedException
+ * @throws ExecutionException
+ */
+ private Map<String, Map<String, Object>> getCurrentTaskMetrics()
Review Comment:
It is better to reuse method above, but I decided not to overbloat scope of
this PR. We can refactor/simplify it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
