kfaraz commented on code in PR #18819:
URL: https://github.com/apache/druid/pull/18819#discussion_r2618214615
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -1662,6 +1664,9 @@ public Map<String, Object> doGetRowStats()
returnMap.put("movingAverages", averagesMap);
returnMap.put("totals", totalsMap);
+ if (this.recordSupplier != null) {
+ returnMap.put("pollIdleRatio",
this.recordSupplier.getPollIdleRatioMetric());
Review Comment:
Let's not put this metric inside top-level map.
It might be better to put this inside another map (at the same level as
`totals` and `movingAverages`) named something like `consumerStats` or
`autoScalerStats`.
Also, please add a query parameter `autoScalerStatsOnly` (false by default)
to the `/rowStats` API so that when the auto-scaler invokes this API, it only
gets back the metrics that it needs. When the query param is false, we would
send back all the stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
