capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2623827025
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -339,6 +353,14 @@ public boolean isTombstone()
return getShardSpec().getType().equals(ShardSpec.Type.TOMBSTONE);
}
+ @Nullable
+ @JsonProperty
+ @JsonInclude(JsonInclude.Include.NON_NULL)
+ public String getCompactionStateFingerprint()
Review Comment:
never compacted*
* = technically a segment without a fingerprint could have been compacted
and have a non-null `lastCompactionState`. But in terms of "has it been
compacted since fingerprinting was enabled", `null` means it has not been.
will clarify in javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
