capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2624082946
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -245,6 +256,9 @@ public DataSegment(
this.binaryVersion = binaryVersion;
Preconditions.checkArgument(size >= 0);
this.size = size;
+ this.compactionStateFingerprint = compactionStateFingerprint != null
+ ?
STRING_INTERNER.intern(compactionStateFingerprint)
+ : null;
Review Comment:
I don't know if I follow the suggestion. shouldn't
`STRING_INTERNER.intern(compactionStateFingerprint)` be the first parameter
since that is the "value" and default (2nd param) will be null? I used the
syntax I did here because it followed pattern for the rest of the constructors
instantiations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
