abhishekrb19 opened a new pull request, #18861:
URL: https://github.com/apache/druid/pull/18861

   Test-only change:
   - Increases test coverage for the DirectDruidClient class from 57%, 35%, 16% 
to 73%, 69%, 43% for method / line / branch coverage respectively. We can add 
more tests as we evolve the code and/or do bug fixes.
   - Replaces mocks with more concrete classes and test helpers, allowing the 
internals of the class, including `HttpResponseHandler` to be exercised.
   - Also added a test for https://github.com/apache/druid/pull/18841 for which 
coverage had to be skipped
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to