kgyrtkirk commented on code in PR #18906:
URL: https://github.com/apache/druid/pull/18906#discussion_r2685206373
##########
extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/aggregation/bloom/sql/BloomFilterSqlAggregatorTest.java:
##########
@@ -78,10 +78,13 @@ public DruidModule getCoreModule()
}
@Override
- public SpecificSegmentsQuerySegmentWalker
addSegmentsToWalker(SpecificSegmentsQuerySegmentWalker walker)
+ public SpecificSegmentsQuerySegmentWalker addSegmentsToWalker(
+ SpecificSegmentsQuerySegmentWalker walker,
+ ObjectMapper jsonMapper
Review Comment:
I think it would be better to give access to the walker thru the injector
`createEmptyWalker#createEmpty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
