clintropolis commented on code in PR #18906:
URL: https://github.com/apache/druid/pull/18906#discussion_r2685350176
##########
extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/aggregation/bloom/sql/BloomFilterSqlAggregatorTest.java:
##########
@@ -78,10 +78,13 @@ public DruidModule getCoreModule()
}
@Override
- public SpecificSegmentsQuerySegmentWalker
addSegmentsToWalker(SpecificSegmentsQuerySegmentWalker walker)
+ public SpecificSegmentsQuerySegmentWalker addSegmentsToWalker(
+ SpecificSegmentsQuerySegmentWalker walker,
+ ObjectMapper jsonMapper
Review Comment:
i thought about that, but also it seemed kind of weird since
`SpecificSegmentsQuerySegmentWalker` doesn't otherwise need a jsonMapper and it
isn't very obvious to callers that there is a mapper that they should be using
for everything their extension might have set up in the component supplier
compared to doing it like this where it is sort of in your face
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
