kfaraz commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2697032939
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -462,6 +466,13 @@ public SegmentPublishResult commitSegmentsAndMetadata(
);
}
);
+
+ // Mark compaction state fingerprints as active after successful publish
+ if (result.isSuccess()) {
+ markIndexingStateFingerprintsAsActive(result.getSegments());
+ }
Review Comment:
+1, it would be cleaner if done in the same transaction, especially since
the underlying task action is meant to be performed within a single transaction.
@capistrant , is there any specific reason for doing it outside the
transaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
