clintropolis commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2697183899
##########
processing/src/main/java/org/apache/druid/guice/DruidSecondaryModule.java:
##########
@@ -164,6 +168,22 @@ public WireTransferableContext getWireTransferableContext(
return new WireTransferableContext(smileMapper, concreteDeserializer,
isUseLegacyFrameSerialization());
}
+ @Provides
+ @LazySingleton
+ @Deterministic
+ public ObjectMapper getSortedMapper(
+ Injector injector,
+ Map<ByteBuffer, WireTransferable.Deserializer> wtDeserializers
+ )
+ {
+ final ObjectMapper sortedMapper = new DefaultObjectMapper();
Review Comment:
>Oh, wouldn't invoking setupJackson take care of that?
I think that would setup the injectable values for `@JacksonInject`, but do
we not need to register the jackson modules from all the druid modules with it
like here?
https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/guice/DruidInjectorBuilder.java#L223
It seems weird to add this mapper there though. Maybe this doesn't matter
all that much because we never deserialize with this mapper, just make some
bytes out of the compaction state... so it doesn't really matter as long as it
serializes to a stable set of bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
