capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2700001358
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2729,25 +2729,23 @@ private void
markIndexingStateFingerprintsAsActive(Set<DataSegment> segments)
}
// Collect unique non-null indexing state fingerprints
- final Set<String> fingerprints = segments.stream()
+ final List<String> fingerprints = segments.stream()
.map(DataSegment::getIndexingStateFingerprint)
.filter(fp -> fp != null &&
!fp.isEmpty())
- .collect(Collectors.toSet());
-
- // Mark each fingerprint as active
- for (String fingerprint : fingerprints) {
- try {
- int rowsUpdated =
indexingStateStorage.markIndexingStatesAsActive(fingerprint);
- if (rowsUpdated > 0) {
- log.info("Marked indexing state fingerprint[%s] as active.",
fingerprint);
- }
- }
- catch (Exception e) {
- // Log but don't fail the overall operation - the fingerprint will
stay pending
- // and be cleaned up by the pending grace period
- log.warn(e, "Failed to mark indexing state fingerprint[%s] as active.
Future segments publishes may remediate", fingerprint);
+ .distinct()
Review Comment:
somehow ended up with an extra space here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
