clintropolis commented on code in PR #18944:
URL: https://github.com/apache/druid/pull/18944#discussion_r2723210596
##########
processing/src/main/java/org/apache/druid/data/input/Rows.java:
##########
@@ -74,15 +77,15 @@ public static List<String> objectToStrings(final Object
inputValue)
return Collections.emptyList();
} else if (inputValue instanceof List) {
// guava's toString function fails on null objects, so please do not use
it
- return ((List<?>)
inputValue).stream().map(String::valueOf).collect(Collectors.toList());
+ return ((List<?>)
inputValue).stream().map(Evals::asString).collect(Collectors.toList());
Review Comment:
it feels worth figuring this out since the old code seems quite odd to be
doing what it is at this layer, so I want to keep looking. It probably would be
fine though if we can't figure it out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
