jtuglu1 commented on code in PR #18944:
URL: https://github.com/apache/druid/pull/18944#discussion_r2742943175
##########
processing/src/main/java/org/apache/druid/segment/RowBasedColumnSelectorFactory.java:
##########
@@ -411,15 +411,14 @@ private void updateCurrentValues()
for (final Object item : ((List) rawValue)) {
final String itemString;
+ // When useStringValueOfNullInLists is true, null items are
converted to the string "null".
+ // When false, null items are preserved as actual null
values, consistent with Rows.objectToStrings.
if (useStringValueOfNullInLists) {
Review Comment:
Yeah I meant to ask about that – I think so. IMO we shouldn't be keeping any
of these older flags since they just cause more migration pain down-the-line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
