github-advanced-security[bot] commented on code in PR #18950:
URL: https://github.com/apache/druid/pull/18950#discussion_r2734847524
##########
processing/src/test/java/org/apache/druid/data/input/impl/DimensionsSpecSerdeTest.java:
##########
@@ -87,4 +87,96 @@
Assert.assertEquals(expected, actual);
Assert.assertEquals(expectedSpatials, actual.getSpatialDimensions());
}
+
+ @Test
+ public void testToBuilder()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2"),
+ new FloatDimensionSchema("dim3")
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2"))
+ .setIncludeAllDimensions(true)
+ .useSchemaDiscovery(false)
+ .setForceSegmentSortByTime(true)
+ .build();
+
+ DimensionsSpec rebuilt = original.toBuilder().build();
+
+ Assert.assertEquals(original, rebuilt);
+ Assert.assertEquals(original.getDimensions(), rebuilt.getDimensions());
+ Assert.assertEquals(original.getDimensionExclusions(),
rebuilt.getDimensionExclusions());
+ Assert.assertEquals(original.isIncludeAllDimensions(),
rebuilt.isIncludeAllDimensions());
+ Assert.assertEquals(original.useSchemaDiscovery(),
rebuilt.useSchemaDiscovery());
+ Assert.assertEquals(original.isForceSegmentSortByTimeConfigured(),
rebuilt.isForceSegmentSortByTimeConfigured());
+ }
+
+ @Test
+ public void testToBuilderWithModifications()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2")
+ )
+ )
+ .setDimensionExclusions(List.of("ex1"))
+ .setIncludeAllDimensions(false)
+ .useSchemaDiscovery(false)
+ .setForceSegmentSortByTime(true)
+ .build();
+
+ DimensionsSpec modified = original.toBuilder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2"),
+ new FloatDimensionSchema("dim3")
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2"))
+ .setForceSegmentSortByTime(false)
+ .build();
+
+ Assert.assertNotEquals(original, modified);
+ Assert.assertNotEquals(original.getDimensions().size(),
modified.getDimensions().size());
+ Assert.assertEquals(3, modified.getDimensions().size());
+ Assert.assertNotEquals(original.getDimensionExclusions().size(),
modified.getDimensionExclusions().size());
+ Assert.assertEquals(2, modified.getDimensionExclusions().size());
+ Assert.assertNotEquals(original.isForceSegmentSortByTimeConfigured(),
modified.isForceSegmentSortByTimeConfigured());
+ }
+
+ @Test
+ public void testToBuilderPreservesAllFields()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new NewSpatialDimensionSchema("spatial1", Arrays.asList("x",
"y"))
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2", "ex3"))
+ .setIncludeAllDimensions(true)
+ .useSchemaDiscovery(true)
+ .setForceSegmentSortByTime(false)
+ .build();
+
+ DimensionsSpec rebuilt = original.toBuilder().build();
+
+ Assert.assertEquals(original.getDimensions(), rebuilt.getDimensions());
+ Assert.assertEquals(original.getDimensionExclusions(),
rebuilt.getDimensionExclusions());
+ Assert.assertEquals(original.isIncludeAllDimensions(),
rebuilt.isIncludeAllDimensions());
+ Assert.assertEquals(original.useSchemaDiscovery(),
rebuilt.useSchemaDiscovery());
+ Assert.assertEquals(original.isForceSegmentSortByTimeConfigured(),
rebuilt.isForceSegmentSortByTimeConfigured());
+ Assert.assertEquals(original.getSpatialDimensions(),
rebuilt.getSpatialDimensions());
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionsSpec.getSpatialDimensions](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10794)
##########
processing/src/test/java/org/apache/druid/data/input/impl/DimensionsSpecSerdeTest.java:
##########
@@ -87,4 +87,96 @@
Assert.assertEquals(expected, actual);
Assert.assertEquals(expectedSpatials, actual.getSpatialDimensions());
}
+
+ @Test
+ public void testToBuilder()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2"),
+ new FloatDimensionSchema("dim3")
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2"))
+ .setIncludeAllDimensions(true)
+ .useSchemaDiscovery(false)
+ .setForceSegmentSortByTime(true)
+ .build();
+
+ DimensionsSpec rebuilt = original.toBuilder().build();
+
+ Assert.assertEquals(original, rebuilt);
+ Assert.assertEquals(original.getDimensions(), rebuilt.getDimensions());
+ Assert.assertEquals(original.getDimensionExclusions(),
rebuilt.getDimensionExclusions());
+ Assert.assertEquals(original.isIncludeAllDimensions(),
rebuilt.isIncludeAllDimensions());
+ Assert.assertEquals(original.useSchemaDiscovery(),
rebuilt.useSchemaDiscovery());
+ Assert.assertEquals(original.isForceSegmentSortByTimeConfigured(),
rebuilt.isForceSegmentSortByTimeConfigured());
+ }
+
+ @Test
+ public void testToBuilderWithModifications()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2")
+ )
+ )
+ .setDimensionExclusions(List.of("ex1"))
+ .setIncludeAllDimensions(false)
+ .useSchemaDiscovery(false)
+ .setForceSegmentSortByTime(true)
+ .build();
+
+ DimensionsSpec modified = original.toBuilder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new LongDimensionSchema("dim2"),
+ new FloatDimensionSchema("dim3")
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2"))
+ .setForceSegmentSortByTime(false)
+ .build();
+
+ Assert.assertNotEquals(original, modified);
+ Assert.assertNotEquals(original.getDimensions().size(),
modified.getDimensions().size());
+ Assert.assertEquals(3, modified.getDimensions().size());
+ Assert.assertNotEquals(original.getDimensionExclusions().size(),
modified.getDimensionExclusions().size());
+ Assert.assertEquals(2, modified.getDimensionExclusions().size());
+ Assert.assertNotEquals(original.isForceSegmentSortByTimeConfigured(),
modified.isForceSegmentSortByTimeConfigured());
+ }
+
+ @Test
+ public void testToBuilderPreservesAllFields()
+ {
+ DimensionsSpec original = DimensionsSpec
+ .builder()
+ .setDimensions(
+ Arrays.asList(
+ new StringDimensionSchema("dim1"),
+ new NewSpatialDimensionSchema("spatial1", Arrays.asList("x",
"y"))
+ )
+ )
+ .setDimensionExclusions(Arrays.asList("ex1", "ex2", "ex3"))
+ .setIncludeAllDimensions(true)
+ .useSchemaDiscovery(true)
+ .setForceSegmentSortByTime(false)
+ .build();
+
+ DimensionsSpec rebuilt = original.toBuilder().build();
+
+ Assert.assertEquals(original.getDimensions(), rebuilt.getDimensions());
+ Assert.assertEquals(original.getDimensionExclusions(),
rebuilt.getDimensionExclusions());
+ Assert.assertEquals(original.isIncludeAllDimensions(),
rebuilt.isIncludeAllDimensions());
+ Assert.assertEquals(original.useSchemaDiscovery(),
rebuilt.useSchemaDiscovery());
+ Assert.assertEquals(original.isForceSegmentSortByTimeConfigured(),
rebuilt.isForceSegmentSortByTimeConfigured());
+ Assert.assertEquals(original.getSpatialDimensions(),
rebuilt.getSpatialDimensions());
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionsSpec.getSpatialDimensions](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10793)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
