capistrant commented on code in PR #18950:
URL: https://github.com/apache/druid/pull/18950#discussion_r2755314317
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionRunner.java:
##########
@@ -42,6 +42,28 @@ public interface CompactionRunner
{
String TYPE_PROPERTY = "type";
+ /**
+ * Returns whether this runner requires aligned intervals for compaction.
+ * When true, the compaction task will throw an error if the IOConfig has
allowNonAlignedInterval enabled.
+ *
+ * @return true if aligned intervals are required by this runner, false
otherwise. Default is true.
+ */
+ default boolean requireAlignedInterval()
+ {
+ return true;
+ }
+
+ /**
+ * Returns whether this runner requires dropExisting to be enabled for
compaction.
+ * When true, the compaction task will fail if dropExisting is not set to
true in the IOConfig.
+ *
+ * @return true if dropExisting must be enabled, false otherwise. Default is
true.
+ */
+ default boolean forceDropExisting()
+ {
+ return true;
Review Comment:
In my test cluster, my msq compact supervisor does start failing to create
tasks after deploying your feature branch. I think this would be a sad change
to force people into making.
`Caused by: org.apache.druid.java.util.common.IAE: Invalid config:
runner[class org.apache.druid.msq.indexing.MSQCompactionRunner] must run with
dropExisting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
