capistrant commented on code in PR #18969:
URL: https://github.com/apache/druid/pull/18969#discussion_r2748042479
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -172,6 +172,7 @@ public int computeTaskCountForScaleAction()
log.info("New task count [%d] on supervisor [%s], scaling up",
taskCount, supervisorId);
} else if (!config.isScaleDownOnTaskRolloverOnly()
&& optimalTaskCount < currentTaskCount
+ && optimalTaskCount > 0
Review Comment:
good sanity check, but is it purely for safety or is it actually possible
for optimalTask count to be invalid in the code as written? If yes, why isn't
that having a lower bound of 1 task or something to make this impossible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
