Fly-Style commented on code in PR #18969:
URL: https://github.com/apache/druid/pull/18969#discussion_r2749149767
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java:
##########
@@ -172,6 +172,7 @@ public int computeTaskCountForScaleAction()
log.info("New task count [%d] on supervisor [%s], scaling up",
taskCount, supervisorId);
} else if (!config.isScaleDownOnTaskRolloverOnly()
&& optimalTaskCount < currentTaskCount
+ && optimalTaskCount > 0
Review Comment:
`optimalTaskCount` may be -1 (which means no changes in task count), and we
don't want to count it as successful scaledown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
