FrankChen021 commented on code in PR #18985:
URL: https://github.com/apache/druid/pull/18985#discussion_r2766731067
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -1097,7 +1097,7 @@ private CloseableIterator<SupervisorStatus>
getAuthorizedSupervisors(
);
Function<SupervisorStatus, Iterable<ResourceAction>> raGenerator =
supervisor -> Collections.singletonList(
-
AuthorizationUtils.DATASOURCE_READ_RA_GENERATOR.apply(supervisor.getSource()));
+
AuthorizationUtils.DATASOURCE_READ_RA_GENERATOR.apply(supervisor.getDataSource()));
Review Comment:
the java doc of orignial getSource says:
```
/**
* This API is only used for informational purposes in
* org.apache.druid.sql.calcite.schema.SystemSchema.SupervisorsTable
*
* @return source like stream or topic name
*/
String getSource();
```
Since here we' re using `getDataSource` I think we should remove the
original getSource method definition. I check the code, besides the
SystemSchema, there're few references in the the kafka supervisor spec, which
can be replaced by calling `getIoConfig().getStream()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
