maytasm commented on code in PR #18985:
URL: https://github.com/apache/druid/pull/18985#discussion_r2773075096
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -1097,7 +1097,7 @@ private CloseableIterator<SupervisorStatus>
getAuthorizedSupervisors(
);
Function<SupervisorStatus, Iterable<ResourceAction>> raGenerator =
supervisor -> Collections.singletonList(
-
AuthorizationUtils.DATASOURCE_READ_RA_GENERATOR.apply(supervisor.getSource()));
+
AuthorizationUtils.DATASOURCE_READ_RA_GENERATOR.apply(supervisor.getDataSource()));
Review Comment:
I don't think that's possible. getIoConfig is not a method of
SupervisorSpec. It is only available in some (but not all) sub classes like
KafkaSupervisorSpec but not CompactionSupervisorSpec. I think we still need
this method (unless you will do a bunch of type checks for each subclass of
SupervisorSpec which i think it's a good idea)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
