kfaraz commented on code in PR #18950:
URL: https://github.com/apache/druid/pull/18950#discussion_r2767250355
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -656,19 +661,32 @@ static Map<Interval, DataSchema>
createDataSchemasForIntervals(
}
}
- private static Iterable<DataSegment> retrieveRelevantTimelineHolders(
- TaskToolbox toolbox,
+ /**
+ * Retrieves data segments and their umbrella interval from the timeline for
the given segment provider.
+ *
+ * @return a pair of umbrella interval and data segments
+ */
+ private static Pair<Interval, Iterable<DataSegment>>
retrieveRelevantTimelineHolder(
Review Comment:
Please avoid using pairs as it sacrifices readability. Instead, let this
method return `Iterabe<DataSegment>` and add a new method to compute the
umbrella interval given the list of segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
