kfaraz commented on code in PR #18950:
URL: https://github.com/apache/druid/pull/18950#discussion_r2767264356
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionRunner.java:
##########
@@ -42,6 +42,14 @@ public interface CompactionRunner
{
String TYPE_PROPERTY = "type";
+ /**
+ * Returns whether this runner requires aligned intervals for compaction.
+ * When true, the compaction task will throw an error if the IOConfig has
allowNonAlignedInterval enabled.
+ *
+ * @return true if aligned intervals are required by this runner, false
otherwise.
+ */
+ boolean requireAlignedInterval();
Review Comment:
Nit: I wonder if we ever allow non-aligned intervals even for native
compaction.
I don't see that field being set while creating auto-compaction tasks.
I feel adding this new method to the `CompactionRunner` interface for a
field which is never used is overkill.
Let's just continue ignoring this field in the MSQ compaction runner as we
do today and just log a warning message in MSQ compaction runner if it is ever
set to `true`.
I think we will just go ahead and deprecate this field and remove it
altogether in a future release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
