clintropolis commented on PR #19004: URL: https://github.com/apache/druid/pull/19004#issuecomment-3899033603
hmm, I still show the added benchmark query as faster with indexes, especially for vectorized processing. I didn't pull your branch, just used apache master with the query added and to test no indexes modified [this line ExpressionVirtualColumn](https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/segment/virtual/ExpressionVirtualColumn.java#L274) to return `NoIndexesColumnIndexSupplier.getInstance()` current master: ``` Benchmark (complexCompression) (deferExpressionDimensions) (jsonObjectStorageEncoding) (query) (rowsPerSegment) (schemaType) (storageType) (stringEncoding) (vectorize) Mode Cnt Score Error Units SqlExpressionBenchmark.querySql NONE singleString SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 437.811 ± 57.658 ms/op SqlExpressionBenchmark.querySql NONE singleString SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 371.432 ± 2.740 ms/op SqlExpressionBenchmark.querySql NONE fixedWidth SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 417.081 ± 10.159 ms/op SqlExpressionBenchmark.querySql NONE fixedWidth SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 368.717 ± 8.266 ms/op SqlExpressionBenchmark.querySql NONE fixedWidthNonNumeric SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 417.167 ± 4.085 ms/op SqlExpressionBenchmark.querySql NONE fixedWidthNonNumeric SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 369.220 ± 10.618 ms/op SqlExpressionBenchmark.querySql NONE always SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 417.864 ± 13.421 ms/op SqlExpressionBenchmark.querySql NONE always SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 344.602 ± 9.518 ms/op ``` modified so that no indexes are used: ``` Benchmark (complexCompression) (deferExpressionDimensions) (jsonObjectStorageEncoding) (query) (rowsPerSegment) (schemaType) (storageType) (stringEncoding) (vectorize) Mode Cnt Score Error Units SqlExpressionBenchmark.querySql NONE singleString SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 505.174 ± 7.250 ms/op SqlExpressionBenchmark.querySql NONE singleString SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 1165.574 ± 37.120 ms/op SqlExpressionBenchmark.querySql NONE fixedWidth SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 501.502 ± 33.384 ms/op SqlExpressionBenchmark.querySql NONE fixedWidth SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 1160.577 ± 43.142 ms/op SqlExpressionBenchmark.querySql NONE fixedWidthNonNumeric SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 501.388 ± 24.289 ms/op SqlExpressionBenchmark.querySql NONE fixedWidthNonNumeric SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 1198.882 ± 57.135 ms/op SqlExpressionBenchmark.querySql NONE always SMILE 61 1500000 explicit MMAP UTF8 false avgt 5 508.851 ± 4.995 ms/op SqlExpressionBenchmark.querySql NONE always SMILE 61 1500000 explicit MMAP UTF8 force avgt 5 1206.142 ± 37.526 ms/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
