clintropolis commented on PR #19004:
URL: https://github.com/apache/druid/pull/19004#issuecomment-3899933482

   ah yea, it is totally that, using the iterator improves the measurement on 
using the indexes quite a lot
   
   with indexes using iterator:
   ```
   Benchmark                        (complexCompression)  
(deferExpressionDimensions)  (jsonObjectStorageEncoding)  (query)  
(rowsPerSegment)  (schemaType)  (storageType)   (stringEncoding)  (vectorize)  
Mode  Cnt    Score     Error  Units
   SqlExpressionBenchmark.querySql                  NONE                 
singleString                        SMILE       61           1500000      
explicit           MMAP  FRONT_CODED_16_V1        false  avgt    5  428.333 ±  
14.320  ms/op
   SqlExpressionBenchmark.querySql                  NONE                 
singleString                        SMILE       61           1500000      
explicit           MMAP  FRONT_CODED_16_V1        force  avgt    5  364.073 ±   
5.671  ms/op
   SqlExpressionBenchmark.querySql                  NONE                   
fixedWidth                        SMILE       61           1500000      
explicit           MMAP  FRONT_CODED_16_V1        false  avgt    5  423.951 ±  
12.710  ms/op
   SqlExpressionBenchmark.querySql                  NONE                   
fixedWidth                        SMILE       61           1500000      
explicit           MMAP  FRONT_CODED_16_V1        force  avgt    5  371.926 ±   
5.133  ms/op
   SqlExpressionBenchmark.querySql                  NONE         
fixedWidthNonNumeric                        SMILE       61           1500000    
  explicit           MMAP  FRONT_CODED_16_V1        false  avgt    5  424.357 ± 
 10.445  ms/op
   SqlExpressionBenchmark.querySql                  NONE         
fixedWidthNonNumeric                        SMILE       61           1500000    
  explicit           MMAP  FRONT_CODED_16_V1        force  avgt    5  419.708 ± 
 71.678  ms/op
   SqlExpressionBenchmark.querySql                  NONE                       
always                        SMILE       61           1500000      explicit    
       MMAP  FRONT_CODED_16_V1        false  avgt    5  444.724 ± 112.962  ms/op
   SqlExpressionBenchmark.querySql                  NONE                       
always                        SMILE       61           1500000      explicit    
       MMAP  FRONT_CODED_16_V1        force  avgt    5  373.843 ±   8.409  ms/op
   ```
   
   thanks for bringing this to attention :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to