capistrant commented on code in PR #18939:
URL: https://github.com/apache/druid/pull/18939#discussion_r2825572747
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -509,7 +509,7 @@ skipInterval, new Interval(remainingStart, remainingEnd)
}
}
- if (!remainingStart.equals(remainingEnd)) {
Review Comment:
ya. I think it is/was generally impossible to hit. but you can't create an
interval if start is after end and this wasn't checking that. It relied on the
caller not passing in params that would cause it to happen. at one point my
code was causing it to happen. But now my safety checks in cascading reindexing
before creating some search intervals that make no sense should prevent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
