Copilot commented on code in PR #19034:
URL: https://github.com/apache/druid/pull/19034#discussion_r2827600753
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2310,7 +2310,9 @@ protected SegmentPublishResult
updateDataSourceMetadataInTransaction(
startMetadataMatchesExisting =
startMetadata.asStartMetadata().matches(oldCommitMetadataFromDb.asStartMetadata());
}
- if (startMetadataGreaterThanExisting && !startMetadataMatchesExisting) {
+ if (startMetadataMatchesExisting) {
+ // Proceed with the commit
+ } else if (startMetadataGreaterThanExisting) {
// Offsets stored in startMetadata is greater than the last commited
metadata.
Review Comment:
Typo in comment: "commited" should be "committed".
```suggestion
// Offsets stored in startMetadata is greater than the last committed
metadata.
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3337,6 +3349,13 @@ public Boolean apply(@Nullable DateTime startTime)
}
}
+ /**
+ * Checks the duration of {@link #activelyReadingTaskGroups}, requests them
+ * to checkpoint themselves if they have exceeded the specified run duration
+ * or if early stop has been requested. If checkpoint is successfull, the
Review Comment:
Typo in the javadoc: "successfull" should be "successful".
```suggestion
* or if early stop has been requested. If checkpoint is successful, the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
