capistrant commented on code in PR #19034:
URL: https://github.com/apache/druid/pull/19034#discussion_r2828645154
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2319,12 +2321,15 @@ protected SegmentPublishResult
updateDataSourceMetadataInTransaction(
+ " end state[%s]. Try resetting the supervisor.",
startMetadata, oldCommitMetadataFromDb
);
- }
-
- if (!startMetadataMatchesExisting) {
- // Not in the desired start state.
+ } else {
+ // startMetadata is older than committed metadata
+ // The task trying to publish is probably a replica trying to commit
offsets already published by another task.
+ // OR the metadata has been updated manually
return SegmentPublishResult.fail(
- "Inconsistency between stored metadata state[%s] and target
state[%s]. Try resetting the supervisor.",
+ "Stored metadata state[%s] has already been updated by other tasks
and"
+ + " has diverged from the expected start metadata state[%s]."
+ + " This task will be replaced by the supervisor with a new task
using updated start offsets."
+ + " Reset the supervisor if the issue persists.",
Review Comment:
nit: I wonder if we are better off suggesting the idea of resetting versus
directing to do it. The new message is much better than the old though since
you offer some reasoning and mention resetting only if it persists rather than
the old message that just says to try resetting it 😜. same apples to all the
error messages in this file and is really just semantics. Trying to reduce the
Druid liability (not that there is such a thing in this sense) if an operator
gets mad cuz they reset without knowing what it does and blames the error
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
