kfaraz commented on code in PR #19051:
URL: https://github.com/apache/druid/pull/19051#discussion_r2850758460
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CascadingReindexingTemplate.java:
##########
@@ -217,6 +243,118 @@ private static boolean intervalEndsAfter(Interval
interval, DateTime boundary)
return interval.getEnd().isAfter(boundary);
}
+ /**
+ * Generates a timeline view showing the search intervals and their
associated reindexing
+ * configurations. This is useful for operators to understand how rules are
applied across
+ * different time periods and to preview the effects of rule changes before
they are applied.
+ *
+ * @param referenceTime the reference time to use for computing rule periods
(typically DateTime.now())
+ * @return a view of the reindexing timeline with intervals and their configs
+ */
+ public ReindexingTimelineView getReindexingTimelineView(DateTime
referenceTime)
Review Comment:
I feel like this method should not live here as it kind of pollutes the
template definition.
Either have the timeline be built using a static method like
`ReindexingTimelineView.fromTemplate(template, referenceTime)` or have a
separate builder class altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
