capistrant commented on PR #19051:
URL: https://github.com/apache/druid/pull/19051#issuecomment-3960543722

   > Was trying out the embedded test in this PR to check out the timeline.
   > 
   > @capistrant , in the snapshot below, what does the "4 rules applied" mean? 
The widget below it shows only 2 items - a segment granularity and a deletion 
rule.
   > 
   > Maybe we should include an info popup for each of the chips. Also, the 
chip says `"1" deletion rule". When can there be more than 1 for a single 
interval?
   > 
   > <img alt="Screenshot 2026-02-25 at 12 50 41 PM" width="807" height="492" 
src="https://private-user-images.githubusercontent.com/18635897/554596525-8df48aa6-b54b-470a-a855-e0330c492bbb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzIwMzczNDcsIm5iZiI6MTc3MjAzNzA0NywicGF0aCI6Ii8xODYzNTg5Ny81NTQ1OTY1MjUtOGRmNDhhYTYtYjU0Yi00NzBhLWE4NTUtZTAzMzBjNDkyYmJiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjI1VDE2MzA0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlODI3ZDZhMjVkYjE2ZTFlZjBmYjcyNzg4NDJlZjM2ZTcxZmM0NDQwMDUyZTc2NDc2MjQ2MzgxNTg1NTE1MDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.boL_Iwu_IreHk7O7BkeJ_Q3UDtzh4iwmTSLlSIbc30E";>
   
   4 rules applied means that the config created for the interval is made up of 
4 different reindexing rules. In this case based on the test I assume you are 
running, it is
   * segmentGran rule
   * deletion rule
   * ioConfig rule
   * tuningConfig rule
   
   You could confirm by clicking the view raw rules button.
   
   I think this is a UX issue. Hand up, I don't have any experience curating a 
good UX :). If I had to guess what UX decision is best here, it is to remove 
the `N rules applied` chip. if someone really wants to see the explicit 
underlying rules they can click view raw rules.
   
   As for deletion rules, N deletion rules can apply to any given interval. 
They accumulate (unlike other rule types). Every deletion rule that applies a 
search interval will be combined together.
   * deleteWhere "countryName=france" olderThan P7D"
   * deleteWhere "countryName=italy" olderThan P14D"
   
   Any interval where both of those apply would have 2 deletion rules.
   
   The chips are intended to give very quick reference to what is in the config 
for the given search interval. They are not strictly tied to rules even. In my 
pictures you see metrics and dims in separate chips, but both belong to the 
same rule. So maybe the deletion rules chip should actually be like 2 deletion 
filters or 2 deletion clauses. I didn't know how valuable chips would be for 
tuningConfig and ioConfig so those are not surfaced, likely leading to your 
initial confusion. You'd have to view the config payload or the raw rules to 
see them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to