aho135 commented on code in PR #19062:
URL: https://github.com/apache/druid/pull/19062#discussion_r2875735615
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -81,15 +84,19 @@ public class BrokerServerView implements TimelineServerView
public BrokerServerView(
final QueryableDruidServer.Maker directDruidClientFactory,
final FilteredServerInventoryView baseView,
- final TierSelectorStrategy tierSelectorStrategy,
+ final TierSelectorStrategy historicalTierSelectorStrategy,
+ @Named(REALTIME_SELECTOR) final TierSelectorStrategy
realtimeTierSelectorStrategy,
Review Comment:
Can we also have @Named for historicalTierSelectorStrategy? This makes
things more explicit in the test code
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -81,15 +84,19 @@ public class BrokerServerView implements TimelineServerView
public BrokerServerView(
final QueryableDruidServer.Maker directDruidClientFactory,
final FilteredServerInventoryView baseView,
- final TierSelectorStrategy tierSelectorStrategy,
+ final TierSelectorStrategy historicalTierSelectorStrategy,
+ @Named(REALTIME_SELECTOR) final TierSelectorStrategy
realtimeTierSelectorStrategy,
Review Comment:
Can we also have `@Named` for historicalTierSelectorStrategy? This makes
things more explicit in the test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
