abhishekrb19 commented on code in PR #19062:
URL: https://github.com/apache/druid/pull/19062#discussion_r2876300651
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -81,15 +84,19 @@ public class BrokerServerView implements TimelineServerView
public BrokerServerView(
final QueryableDruidServer.Maker directDruidClientFactory,
final FilteredServerInventoryView baseView,
- final TierSelectorStrategy tierSelectorStrategy,
+ final TierSelectorStrategy historicalTierSelectorStrategy,
+ @Named(REALTIME_SELECTOR) final TierSelectorStrategy
realtimeTierSelectorStrategy,
Review Comment:
Hmm agreed, that would make it clearer for the historical one as well.
However, it would require introducing a separate provider to bind the `@Named`
variant and move the existing bindings from `CliBroker`, since the same class
cannot be bound multiple times in Guice. I punted on that for now in favor of a
brief comment here indicating where these bindings are injected from. Hopefully
that clarifies it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
