capistrant commented on code in PR #19071:
URL: https://github.com/apache/druid/pull/19071#discussion_r2879609731


##########
extensions-core/kubernetes-overlord-extensions/pom.xml:
##########
@@ -139,12 +142,17 @@
     <dependency>
       <groupId>com.squareup.okhttp3</groupId>
       <artifactId>okhttp</artifactId>
-      <version>4.12.0</version>
+      <version>5.3.2</version>

Review Comment:
   for this extension in particular, no. It is a minimum req for the the 
upgraded fabric8 library. We just pull the dependency explicitly to configure 
some dispatcher stuff under the hood.
   
   re multiple okhttp versions, I think I'm going to pivot this PR to be a bit 
wider to keep this in sync. in the druid-kubernetes-extensions, we have fallen 
way behind on the native k8s client version. If we update that we can support 
okhttp 5 across both. the upgrade seems straightforward and testing locally has 
been positive



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to