gianm commented on code in PR #19071:
URL: https://github.com/apache/druid/pull/19071#discussion_r2877034586
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/httpclient/vertx/DruidKubernetesVertxHttpClientFactory.java:
##########
@@ -19,31 +19,51 @@
package org.apache.druid.k8s.overlord.common.httpclient.vertx;
-import io.fabric8.kubernetes.client.vertx.VertxHttpClientBuilder;
+import com.fasterxml.jackson.databind.ObjectMapper;
import io.fabric8.kubernetes.client.vertx.VertxHttpClientFactory;
import io.vertx.core.Vertx;
import io.vertx.core.VertxOptions;
import io.vertx.core.file.FileSystemOptions;
import io.vertx.core.spi.resolver.ResolverProvider;
+import io.vertx.ext.web.client.WebClientOptions;
+import org.apache.druid.java.util.common.logger.Logger;
import
org.apache.druid.k8s.overlord.common.httpclient.DruidKubernetesHttpClientFactory;
/**
* Similar to {@link VertxHttpClientFactory} but allows us to override thread
pool configurations.
*/
-public class DruidKubernetesVertxHttpClientFactory implements
DruidKubernetesHttpClientFactory
+public class DruidKubernetesVertxHttpClientFactory extends
VertxHttpClientFactory implements DruidKubernetesHttpClientFactory
{
public static final String TYPE_NAME = "vertx";
- private final Vertx vertx;
- public DruidKubernetesVertxHttpClientFactory(final
DruidKubernetesVertxHttpClientConfig httpClientConfig)
+ private static final Logger LOG = new
Logger(DruidKubernetesVertxHttpClientFactory.class);
+ private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
Review Comment:
I suppose it's fine not to use the server's `ObjectMapper` here, but it
would still be cleaner to, I think. It avoids having this static lying around
when it isn't going to be used after server startup.
##########
extensions-core/kubernetes-overlord-extensions/pom.xml:
##########
@@ -139,12 +142,17 @@
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
- <version>4.12.0</version>
+ <version>5.3.2</version>
Review Comment:
Anything to worry about with this major upgrade?
The same `okhttp-4.12.0` is also used in `druid-kubernetes-extensions`.
Possible to keep these consistent and update that one too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
