leventov commented on a change in pull request #7154: rename maintenance mode
to decommission
URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r263576040
##########
File path:
server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java
##########
@@ -251,28 +251,28 @@ public void testMoveMaintenancePriority()
}
@Test
- public void testZeroMaintenancePriority()
+ public void testZeroDecommissioningMaxPercentOfMaxSegmentsToMove()
{
- DruidCoordinatorRuntimeParams params =
setupParamsForMaintenancePriority(0);
+ DruidCoordinatorRuntimeParams params =
setupParamsForDecommissioningMaxPercentOfMaxSegmentsToMove(0);
params = new DruidCoordinatorBalancerTester(coordinator).run(params);
Assert.assertEquals(1L,
params.getCoordinatorStats().getTieredStat("movedCount", "normal"));
Assert.assertThat(peon3.getSegmentsToLoad(),
is(equalTo(ImmutableSet.of(segment1))));
}
@Test
- public void testMaxMaintenancePriority()
+ public void testMaxDecommissioningMaxPercentOfMaxSegmentsToMove()
{
- DruidCoordinatorRuntimeParams params =
setupParamsForMaintenancePriority(10);
+ DruidCoordinatorRuntimeParams params =
setupParamsForDecommissioningMaxPercentOfMaxSegmentsToMove(10);
params = new DruidCoordinatorBalancerTester(coordinator).run(params);
Assert.assertEquals(1L,
params.getCoordinatorStats().getTieredStat("movedCount", "normal"));
Assert.assertThat(peon3.getSegmentsToLoad(),
is(equalTo(ImmutableSet.of(segment2))));
}
/**
- * Should balance segments as usual (ignoring priority) with empty
maintenanceList.
+ * Should balance segments as usual (ignoring percent) with empty
decommissioningList.
Review comment:
Perhaps meant decommissioningNodes, not decommissioningList
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
