gianm commented on PR #18813: URL: https://github.com/apache/druid/pull/18813#issuecomment-4000853456
> @gianm @clintropolis do you know why many `VectorAggregator` implementations(2 examples below): > > * [NullableNumericVectorAggregator](https://github.com/apache/druid/blob/-/processing/src/main/java/org/apache/druid/query/aggregation/NullableNumericVectorAggregator.java#L116-L117) > > * [DoubleHllSketchBuildVectorProcessor](https://github.com/apache/druid/blob/master/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/vector/DoubleHllSketchBuildVectorProcessor.java#L62-L66) > > > use the `rows` index to check whether the row being accessed is `null`, but [ApproximateHistogramVectorAggregator](https://github.com/apache/druid/blob/-/extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramVectorAggregator.java#L75-L78) does not index into this null vector with the `rows` index to fetch that information (and instead uses `i` directly)?. > > in other words: using `selector.getNullVector()[i]` vs `selector.getNullVector()[rows != null ? rows[i] : i]`? It looks like a bug in `ApproximateHistogramVectorAggregator` to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
