kfaraz commented on code in PR #19091:
URL: https://github.com/apache/druid/pull/19091#discussion_r2897215575
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalInsertAction.java:
##########
@@ -323,6 +328,19 @@ private static Map<Interval, List<DataSegment>>
groupSegmentsByIntervalAndSort(S
return segmentsMap;
}
+ /**
+ * A failed publish action should be retried only if there is another task
+ * waiting to publish offsets for an overlapping set of partitions.
+ */
+ private boolean shouldNotRetryFailure(SegmentPublishResult result, Task
task, TaskActionToolbox toolbox)
+ {
+ if (result.isSuccess() || !result.isRetryable() || startMetadata != null) {
Review Comment:
Ah, yes, thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
