capistrant commented on code in PR #19091:
URL: https://github.com/apache/druid/pull/19091#discussion_r2906284593
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalInsertAction.java:
##########
@@ -323,6 +328,24 @@ private static Map<Interval, List<DataSegment>>
groupSegmentsByIntervalAndSort(S
return segmentsMap;
}
+ /**
+ * Checks if the current publish action should be failed without allowing any
+ * more retries. A failed publish action should be retried only if there is
+ * another task waiting to publish offsets for an overlapping set of
partitions.
+ */
+ private boolean shouldFailImmediately(SegmentPublishResult result, Task
task, TaskActionToolbox toolbox)
Review Comment:
applies to both impls of `shouldFailImmediately`
I am confused, if `isAnotherTaskGroupPublishingToPartitions` returns true
doesn't that mean we **do not** want to fail immediately? But the way I read
this is that this case returns `true`, fail immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
