jtuglu1 commented on code in PR #19126:
URL: https://github.com/apache/druid/pull/19126#discussion_r2916847354
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -60,7 +60,7 @@ jobs:
uses: ./.github/workflows/docker-tests.yml
actions-timeline:
- needs: [unit-tests, docker-tests]
+ needs: [unit-tets, docker-tests]
Review Comment:
lgtm pending this update
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/DruidContainerResource.java:
##########
@@ -154,7 +154,7 @@ public void beforeStart(EmbeddedDruidCluster cluster)
);
// Mount directories used by this container for easier debugging with
service logs
- this.containerDirectory = cluster.getTestFolder().getOrCreateFolder(name);
+ this.containerDirectory = new File("druid-container-logs", name);
Review Comment:
I assume this won't race with other concurrent container resources writing
logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
