kfaraz commented on code in PR #19126:
URL: https://github.com/apache/druid/pull/19126#discussion_r2916875972


##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/DruidContainerResource.java:
##########
@@ -154,7 +154,7 @@ public void beforeStart(EmbeddedDruidCluster cluster)
     );
 
     // Mount directories used by this container for easier debugging with 
service logs
-    this.containerDirectory = cluster.getTestFolder().getOrCreateFolder(name);
+    this.containerDirectory = new File("druid-container-logs", name);

Review Comment:
   Currently, we don't exactly support running embedded tests concurrently 
(mostly due to the port bindings which are likely to have conflicts when 
running multiple clusters without the port properties overridden).
   
   But I guess, we can use a unique `clusterId` here to avoid conflicts. Let me 
see if I can add that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to