ashwintumma23 commented on code in PR #19135:
URL: https://github.com/apache/druid/pull/19135#discussion_r2921501897
##########
pom.xml:
##########
@@ -119,16 +119,14 @@
<hadoop.compile.version>3.3.6</hadoop.compile.version>
<graaljs.version>22.3.5</graaljs.version>
<mockito.version>5.14.2</mockito.version>
- <aws.sdk.version>1.12.793</aws.sdk.version>
+ <aws.sdk.version>1.12.784</aws.sdk.version>
<caffeine.version>2.8.0</caffeine.version>
<jacoco.version>0.8.14</jacoco.version>
<testcontainers.version>2.0.3</testcontainers.version>
<hibernate-validator.version>6.2.5.Final</hibernate-validator.version>
<httpclient.version>4.5.13</httpclient.version>
- <okhttp.version>5.3.2</okhttp.version>
- <kubernetes.client.version>25.0.0-legacy</kubernetes.client.version>
<!-- When upgrading ZK, edit docs and integration tests as well
(integration-tests/docker-base/setup.sh) -->
Review Comment:
Thanks for the review, @abhishekrb19 !
* Agreed on both points — removed the stale comment.
* The docs no longer need a manual update per #18836.
* As for the integration tests, `ZK_VERSION` is sourced transitively from
this property: `integration-tests/pom.xml` maps it as
`<ZK_VERSION>${zookeeper.version}</ZK_VERSION>` via the Failsafe plugin, which
exports it into the shell environment. `docker_build_containers.sh` then passes
it through as `--build-arg ZK_VERSION`, and `Dockerfile` picks it up as `ARG
ZK_VERSION` before base-setup.sh consumes it. So updating the root `pom.xml`
property is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
