kfaraz commented on code in PR #19140:
URL: https://github.com/apache/druid/pull/19140#discussion_r2922290186
##########
server/src/main/java/org/apache/druid/server/http/BaseDynamicConfigSyncer.java:
##########
@@ -180,6 +180,10 @@ private void pushConfigToBrokerNode(DiscoveryDruidNode
broker)
{
final Stopwatch stopwatch = Stopwatch.createStarted();
final ServiceLocation brokerLocation =
convertDiscoveryNodeToServiceLocation(broker);
+ if (brokerLocation == null) {
+ log.warn("Skipping broker sync - could not convert to ServiceLocation:
[%s]", broker);
Review Comment:
Nit: Should this log be moved to the `convertDiscoveryNode` since it has
more information about why the service location could not be determined (e.g.
`DruidNode` is null)?
```suggestion
log.warn("Skipping config sync for broker[%s] as its ServiceLocation
could not be determined.", broker);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
