gianm commented on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-470765890 It sounds like the approaches being proposed are, @drcrallen's proposal, embodied in #6948, to keep ourselves at Guava 16.0.1, but endeavor, through reflection and some limited copying, to be compatible with a wide range of Guava versions that may get subbed in at runtime. @leventov's proposal, to copy the entire, latest Guava source tree into Druid, like we've done for Closer and some utility functions in the past. I feel like @leventov's approach has a certain appeal to it -- it's simple, and 'guaranteed to work'. If we did it, it should really be done in an automated fashion, so we can easily stay up to date. But @drcrallen's has appeal too. A wholesale copy of a relatively large project like Guava into Druid is a bit ugly, so @drcrallen's approach is more elegant in my eyes. And we don't have to maintain a system that automates copying Guava into Druid as Guava evolves. And it gives users more control over what Guava version they run. #6948 also has the advantage of already being coded up. And, if we use the Guava 11 and Guava 'latest' profiles in CI, we can make sure that we are _actually_ compatible, giving us that 'guaranteed to work' assurance. For these reasons, my opinion is let's go with @drcrallen's proposal.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
