gianm commented on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-471842698 > @gianm, your analysis also misses the main point and the advantage of the approach that I suggested: we are able to use latest Guava features, such as MoreCollectors, and more. I had to explain this earlier in the thread. Well, that's a good point. Why not merge #6948 (which works & solves a real problem) and then potentially implement a source-copying script later? At the time we do that - probably motivated by wanting to use some new Guava features - I think ideally it only copies certain files from Guava. It's simpler to copy the entire tree, but ugly, since it would involve relocating a lot of stuff we don't use. So for tidiness purposes it seems worth it to maintain a list of files we want to copy and a script that copies just those files from a particular, provided Guava version.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
